Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feature) Adds optional keep_alived firewall rules to task 3.5.1.6 #46

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

jvleminc
Copy link
Collaborator

@jvleminc jvleminc commented Mar 15, 2021

  • (feature) Adds optional keep_alived firewall rules to task 3.5.1.6
  • (chore) Changes some "false" to "no", for consistency reasons. Adds some comments. Changes variable name to use "firewall" and not "ufw".

@jvleminc jvleminc requested a review from alivx March 15, 2021 16:29
ufw:
# note: Ansible doesn't support "proto: vrrp"
rule: allow
from_ip: 224.0.0.18
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set a dynamic config for this static IP

Copy link
Collaborator Author

@jvleminc jvleminc Mar 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, not needed, this is the broadcast IP used by VRRP.

https://tools.ietf.org/html/rfc3768:

The IP multicast address as assigned by the IANA for VRRP is:

      224.0.0.18

   This is a link local scope multicast address.  Routers MUST NOT
   forward a datagram with this destination address regardless of its
   TTL.

ufw:
# note: Ansible doesn't support "proto: vrrp"
rule: allow
to_ip: 224.0.0.18
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we set a dynamic config for this static IP

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idem

@alivx alivx merged commit e1027fa into master Mar 16, 2021
@alivx alivx deleted the feature/Adds_keep_alived_firewall_rules branch November 25, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants