Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.2.x #240

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

10.2.x #240

wants to merge 2 commits into from

Conversation

bytespider
Copy link

Updated to support Puppeteer 10.2.x

@bestplay9384
Copy link

Chromium version has changed. You still need to build up a binary via ansible & AWS.

@bytespider
Copy link
Author

I assume that's the job of the workflow / build step

@bestplay9384
Copy link

bestplay9384 commented Sep 24, 2021

As far as i know - it is not. There is an ansible script that needs to be given AWS Credentials to be possible to build a binary, but historically it was run by @alixaxel so he individually prepared all chromium binaries :/

@alixaxel
Copy link
Owner

@bestplay9384 Indeed, I will take care of this in the next hours.

@bytespider
Copy link
Author

I tried running it myself but my Debian VM would.hang part way through and the EC2 instance left running doing nothing.

@hooman-myadbox
Copy link

Anyone has managed to get this working?

@bytespider
Copy link
Author

@hooman-myadbox I decided to use container images with the native Alpine Chromium binary installed since this PR didn't seem to get much traction.
https://aws.amazon.com/blogs/aws/new-for-aws-lambda-container-image-support/

Repository owner deleted a comment from lifesaverluke Nov 5, 2021
@Sparticuz Sparticuz mentioned this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants