chore: throw custom errors in tag processing #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RM-66 Throw custom errors for tag processing
The bug (reported 2x) seems to be happening at the processing step of tags data, but hard to debug remotely without doing some backend work. Work Add custom error throwing in all the processing steps for tags, so the problem can bubble up |
Codecov Report
@@ Coverage Diff @@
## beta #126 +/- ##
==========================================
+ Coverage 86.76% 86.82% +0.06%
==========================================
Files 122 122
Lines 4048 4064 +16
Branches 1159 1163 +4
==========================================
+ Hits 3512 3528 +16
- Misses 521 522 +1
+ Partials 15 14 -1
|
alixlahuec
deleted the
feature/rm-66-throw-custom-errors-for-tag-processing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few users have reported failed requests for tags, and the error seems to come from the processing step rather than the request itself (network calls are successful,
tagsdata is logged). This PR adds error throwing to the different functions involved in processing tags, to narrow down the origin of the problem.Validation
✅ Unit testing with Jest
❌ No dev build / manual testing, since the cause of the problem is unclear