Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable minimize in Storybook webpack config #336

Merged
merged 3 commits into from
Jun 17, 2023

Conversation

alixlahuec
Copy link
Owner

@alixlahuec alixlahuec commented Jun 17, 2023

Closes RM-373

@linear
Copy link

linear bot commented Jun 17, 2023

RM-373 Disable minimize in Storybook webpack

CI is running fine, but npm run build-storybook fails locally (OOM). Update main.ts to disable minimize (see storybookjs/storybook#6408 (comment))

@codecov
Copy link

codecov bot commented Jun 17, 2023

Codecov Report

Merging #336 (28febfe) into beta (12a675b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             beta     #336   +/-   ##
=======================================
  Coverage   88.76%   88.76%           
=======================================
  Files         130      130           
  Lines        4065     4065           
  Branches     1194     1194           
=======================================
  Hits         3608     3608           
  Misses        454      454           
  Partials        3        3           

@alixlahuec alixlahuec marked this pull request as ready for review June 17, 2023 15:58
@alixlahuec alixlahuec merged commit 6055878 into beta Jun 17, 2023
10 checks passed
@alixlahuec alixlahuec deleted the feature/rm-373-disable-minimize-in-storybook-webpack branch June 17, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant