Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test for sdk/config #97

Merged
merged 1 commit into from Nov 6, 2018
Merged

Improve test for sdk/config #97

merged 1 commit into from Nov 6, 2018

Conversation

JacksonTian
Copy link
Contributor

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #97 into master will increase coverage by 1.47%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
+ Coverage   22.41%   23.89%   +1.47%     
==========================================
  Files          22       22              
  Lines        1169     1172       +3     
==========================================
+ Hits          262      280      +18     
+ Misses        863      848      -15     
  Partials       44       44
Impacted Files Coverage Δ
sdk/config.go 100% <100%> (+48.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c82561...86fbd95. Read the comment docs.

@JacksonTian JacksonTian merged commit 645fae3 into master Nov 6, 2018
@JacksonTian JacksonTian deleted the cov branch November 6, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants