Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to build against credentials-go-1.1.0 #300

Closed
wants to merge 2 commits into from

Conversation

bdperkin
Copy link

We are packaging aliyun-cli for Fedora 33. As part of the process, we need to have the latest version of all necessary libraries. As of now, credentials-go-1.1.0 is the latest version. Based on the following commit:

aliyun/credentials-go@065ea15#diff-56f4af8e6f3d6ba188d70ad5d855cdba

I made the similar modifications needed to get the Aliyun CLI to build.

@night556
Copy link
Member

Thank you for your PR, but due to the following reasons, we will not merge this modification:

  1. CLI code is not intended to be dependent on as a library
  2. We do not require this style to be consistent
  3. Other reasons

Thanks again for your PR.

@JacksonTian
Copy link
Contributor

The latest CLI has build with the new credentials-go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants