improve get protocol method for https #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonTian
force-pushed
the
https
branch
2 times, most recently
from
c085e8a
to
39725db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
==========================================
- Coverage 79.06% 79.01% -0.05%
==========================================
Files 47 47
Lines 4050 4103 +53
==========================================
+ Hits 3202 3242 +40
- Misses 713 723 +10
- Partials 135 138 +3 ☔ View full report in Codecov by Sentry. |
yndu13
reviewed
Apr 12, 2024
openapi/rpc.go
Outdated
| @@ -38,6 +38,11 @@ func (a *RpcInvoker) Prepare(ctx *cli.Context) error { | |||
| request.Scheme = api.GetProtocol() | |||
| request.Method = api.GetMethod() | |||
|
|
|||
| // if `--insecure` assigned, use https | |||
| if _, ok := InsecureFlag(ctx.Flags()).GetValue(); ok { | |||
| a.request.Scheme = "https" | |||
yndu13
approved these changes
Apr 12, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.