Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeRequest missing http method #74

Closed
tobyfan1980 opened this issue Oct 17, 2019 · 2 comments
Closed

makeRequest missing http method #74

tobyfan1980 opened this issue Oct 17, 2019 · 2 comments

Comments

@tobyfan1980
Copy link

  • Product and API:
  • Platform:
  • How to Reproduce

the generated code shows that when client class calls makeRequest, it does not set the third parameter HttpRequest::Method, as a result, all requests are using GET.

following code is an example of a generated POST api

EasClient::CreateServiceOutcome EasClient::createService(const CreateServiceRequest &request) const
{
	auto endpointOutcome = endpointProvider_->getEndpoint();
	if (!endpointOutcome.isSuccess())
		return CreateServiceOutcome(endpointOutcome.error());

	auto outcome = makeRequest(endpointOutcome.result(), request);

	if (outcome.isSuccess())
		return CreateServiceOutcome(CreateServiceResult(outcome.result()));
	else
		return CreateServiceOutcome(outcome.error());
}
@AxiosLeo
Copy link
Contributor

thanks for your feedback.

It will be fixed in the next commit.

AxiosLeo pushed a commit that referenced this issue Oct 25, 2019
AxiosLeo pushed a commit that referenced this issue Oct 25, 2019
AxiosLeo pushed a commit that referenced this issue Oct 25, 2019
ghost pushed a commit that referenced this issue Oct 25, 2019
@AxiosLeo
Copy link
Contributor

AxiosLeo commented Oct 29, 2019

fixed in #74,#75

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants