Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide more information when error occurs #37

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

zhangzifa
Copy link
Contributor

No description provided.

Copy link
Contributor

@JacksonTian JacksonTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

Copy link
Contributor

@JacksonTian JacksonTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMC

core/src/CurlHttpClient.cc Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 26, 2019

Codecov Report

Merging #37 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #37      +/-   ##
==========================================
+ Coverage   94.44%   94.45%   +0.01%     
==========================================
  Files          66       66              
  Lines        1601     1605       +4     
==========================================
+ Hits         1512     1516       +4     
  Misses         89       89
Impacted Files Coverage Δ
core/src/CoreClient.cc 94.87% <100%> (+0.27%) ⬆️
core/src/CurlHttpClient.cc 94.93% <100%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f877a9e...07ac368. Read the comment docs.

@JacksonTian JacksonTian merged commit 33a44c8 into master Feb 27, 2019
@AxiosLeo AxiosLeo deleted the more_error_message_to_user branch August 14, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants