区分signature错误和ak错误 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssy352959096
force-pushed
the
AcsRequest
branch
from
75f1b63
to
d7feb68
Compare
JacksonTian
reviewed
Jan 9, 2019
| try { | ||
| client.distinguishError(request, error, baseResponse); | ||
| } catch (Exception e) { | ||
| Assert.assertEquals("500 : ServerException", e.getMessage()); |
There was a problem hiding this comment.
如果期待报错，用ExpectedException来做
There was a problem hiding this comment.
distinguishError()这个方法建议改成private的，不能为了方便测试而改成public的
There was a problem hiding this comment.
DefaultAcsClient不太适合提供distinguishError的功能，并且暴露给用户，这个函数建议可以放到工具类里面，这样也容易测试
JacksonTian
reviewed
Jan 9, 2019
| try { | ||
| client.distinguishError(request, error, baseResponse); | ||
| } catch (Exception e) { | ||
| Assert.assertEquals("InvalidAccessSecret : Specified Access Key Secret is not valid.", e.getMessage()); |
There was a problem hiding this comment.
review 的时候说过多少次了 InvalidAccessKeySecret 不是 InvalidAccessSecret
JacksonTian
reviewed
Jan 9, 2019
| try { | ||
| client.distinguishError(request, error, baseResponse); | ||
| } catch (ClientException e) { | ||
| Assert.fail(); |
There was a problem hiding this comment.
这里要断言，code 不是 InvalidAccessKeySecret
JacksonTian
requested changes
Jan 9, 2019
| Mockito.when(error.getErrorCode()).thenReturn("error"); | ||
| try { | ||
| client.distinguishError(request, error, baseResponse); | ||
| } catch (ClientException e) { |
sjj3086786
reviewed
Jan 9, 2019
| } | ||
| } | ||
|
|
||
| public void distinguishError(AcsRequest request, AcsError error, HttpResponse baseResponse) throws ClientException { |
There was a problem hiding this comment.
public -> private 是不是好一点
ssy352959096
force-pushed
the
AcsRequest
branch
from
d7feb68
to
cef5ff6
Compare
JacksonTian
reviewed
Jan 9, 2019
| } | ||
| } | ||
|
|
||
| public <T extends AcsResponse> T distinguishError(AcsRequest<T> request, AcsError error, HttpResponse baseResponse) throws ClientException { |
ssy352959096
force-pushed
the
AcsRequest
branch
from
cef5ff6
to
8d2abf5
Compare
JacksonTian
approved these changes
Jan 10, 2019
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
============================================
+ Coverage 70.92% 71.77% +0.84%
- Complexity 845 856 +11
============================================
Files 88 88
Lines 3006 3015 +9
Branches 305 308 +3
============================================
+ Hits 2132 2164 +32
+ Misses 809 782 -27
- Partials 65 69 +4
Continue to review full report at Codecov.
|
ssy352959096
force-pushed
the
AcsRequest
branch
from
4e0b973
to
9785f50
Compare
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.