Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #123: Remove redundant dependency 'jersey' #149

Merged
merged 1 commit into from
Dec 21, 2018

Conversation

fuyufjh
Copy link
Contributor

@fuyufjh fuyufjh commented Jul 27, 2018

Currently we use jersey-json as a dependency, but actually in java code only one dependency of jersey-json - jettison is being used.

As #123 said, com.sun.jersey:jersey:1.x is an obsolete library and it caused several collision with other libraries (In my case, it breaks RestAPI of Spark). The best solution is to just remove it.

@CLAassistant
Copy link

CLAassistant commented Jul 27, 2018

CLA assistant check
All committers have signed the CLA.

@fuyufjh
Copy link
Contributor Author

fuyufjh commented Jul 27, 2018

Difference of mvn dependency:tree

Before:

[INFO] +- com.sun.jersey:jersey-json:jar:1.9:compile
[INFO] |  +- org.codehaus.jettison:jettison:jar:1.1:compile
[INFO] |  |  \- stax:stax-api:jar:1.0.1:compile
[INFO] |  +- com.sun.xml.bind:jaxb-impl:jar:2.2.3-1:compile
[INFO] |  |  \- javax.xml.bind:jaxb-api:jar:2.2.2:compile
[INFO] |  |     +- javax.xml.stream:stax-api:jar:1.0-2:compile
[INFO] |  |     \- javax.activation:activation:jar:1.1:compile
[INFO] |  +- org.codehaus.jackson:jackson-core-asl:jar:1.8.3:compile
[INFO] |  +- org.codehaus.jackson:jackson-mapper-asl:jar:1.8.3:compile
[INFO] |  +- org.codehaus.jackson:jackson-jaxrs:jar:1.8.3:compile
[INFO] |  +- org.codehaus.jackson:jackson-xc:jar:1.8.3:compile
[INFO] |  \- com.sun.jersey:jersey-core:jar:1.9:compile

After:

[INFO] +- org.codehaus.jettison:jettison:jar:1.1:compile
[INFO] |  \- stax:stax-api:jar:1.0.1:compile

@fuyufjh fuyufjh changed the title Issue 123: Remove dependency 'jersey' and add 'jettison' Fix #123: Remove redundant dependency 'jersey' Jul 27, 2018
@fuyufjh
Copy link
Contributor Author

fuyufjh commented Aug 7, 2018

Anyone helps to review this PR? @tonyxuqqi @dengwu12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants