symlink #51
Merged
symlink #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eltonxiao
reviewed
Oct 31, 2016
| * @throws OSSException OSS Server异常信息。 | ||
| * @throws ClientException OSS Client异常信息。 | ||
| */ | ||
| public void createSymbolicLink(String bucketName, String symLink, String targetObject) |
eltonxiao
reviewed
Oct 31, 2016
| String key = genericRequest.getKey(); | ||
|
|
||
| assertParameterNotNull(bucketName, "bucketName"); | ||
| assertParameterNotNull(key, "symLink"); |
eltonxiao
reviewed
Oct 31, 2016
| * Test Symbolic Link | ||
| */ | ||
| public class SymbolicLinkTest extends TestBase { | ||
|
|
There was a problem hiding this comment.
case有点少；建议加入case: 目标为中文文件名； Get Object时，目标鉴权失败时的行为；目标不存在时的行为；目标为symlink的行为；
There was a problem hiding this comment.
创建symbolic时,
- 不检查link target是否存在
- 不检查link target类型是否合法
- 不检查link target是否有权限访问
以上检查，都推迟到GetObject等需要访问link target的API。
另外，SDK不会测试feature的所有特性，feature的功能有它的case保证。SDK只需要保证SDK的正确性即可。API文档中会对这些行为给出说明。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持sym link功能。添加两个接口：