New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oss select #114
Merged
Merged
Oss select #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
three APIs: select_object: select object content to memory select_object_to_file:select object to file head_csv_object: head csv object
…change 1) The end frame's checksum bytes are now in the end of the frame (after the status and error message) 2) also remove the use of make_progress_adapter cause the SelectFrameResponse includes the progress update function
The attribute is used for progress update
The x-oss-select-total-bytes-to-scan is removed in server's behavior and thus the SDK needs the change as well.
1) rename select API name to select_object, select_object_to_file, get_select_object_meta. 2) Rename FileHeaderInfo with CsvHeaderInfo 3) Rename HeadCsvObjectResult with 4) rename CsvRow, CsvSplit with csv_row, csv_split 5) move constants to class SelectResponseAdapter 6) rename SelectFrameResponse with SelectResponseAdapter and add comments on the format
remove unneeded code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSS select API