Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete duplicate bucket creation #170

Closed
wants to merge 6 commits into from

Conversation

liyanzhang505
Copy link
Contributor

Delete duplicate bucket creation

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


LYZ seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

Coverage Status

Coverage decreased (-32.02%) to 63.67% when pulling c57f0ac on liyanzhang505:check-branch into 4b1d079 on aliyun:master.

@coveralls
Copy link

coveralls commented Apr 12, 2019

Coverage Status

Coverage decreased (-32.02%) to 63.67% when pulling 2befdf9 on liyanzhang505:check-branch into 4b1d079 on aliyun:master.

@@ -52,6 +52,8 @@ def test_local_file(self):
self.assertEqual(self.bucket.get_object(key2).read(), content)

os.remove(u'中文本地文件名.txt')
self.bucket.delete_object(key)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key这里可以不用显示的删除,在tearDown调用里面会统一删

#list all object to delete
obj_iter = oss2.ObjectIterator(bucket)
for obj in obj_iter:
bucket.delete_object(obj.key)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还要加个 live channel 相关的清理

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already added

@hangzws hangzws closed this Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants