bucket tagging & bucket encryption & bucket version #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
huiguangjun
reviewed
May 15, 2019
oss2/__init__.py
Outdated
| @@ -23,9 +23,10 @@ | |||
| from .utils import http_date, http_to_unixtime, iso8601_to_unixtime, date_to_iso8601, iso8601_to_date | |||
|
|
|||
|
|
|||
| from .models import BUCKET_ACL_PRIVATE, BUCKET_ACL_PUBLIC_READ, BUCKET_ACL_PUBLIC_READ_WRITE | |||
| from .models import BUCKET_ACL_PRIVATE, BUCKET_ACL_PUBLIC_READ, BUCKET_ACL_PUBLIC_READ_WRITE, SERVER_SIDE_ENCRYPTION_AES, SERVER_SIDE_ENCRYPTION_KMS | |||
There was a problem hiding this comment.
SERVER_SIDE_ENCRYPTION_AES 最好修改为 SERVER_SIDE_ENCRYPTION_AES256
kkuai
reviewed
May 16, 2019
| else: | ||
| bucket.get_object_to_file(key, filename, progress_callback=progress_callback) | ||
| bucket.get_object_to_file(key, filename, progress_callback=progress_callback, params=params) |
| params={'uploadId': target_upload_id, | ||
| 'partNumber': str(target_part_number)}, | ||
| headers=headers) | ||
| params=params,headers=headers) |
There was a problem hiding this comment.
这里应该把versionid从params里面去掉了，因为已经取出来放到header里面了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.