add raw buffer mode #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CiCi503
force-pushed
the
add_raw_buffer_mode
branch
from
646773c
to
49829e2
Compare
rockuw
reviewed
Nov 13, 2018
| @@ -18,7 +18,7 @@ Notice | |||
| ------------------- | |||
| We suggest using fc2，The main difference between fc and fc2 is: | |||
|
|
|||
| The response returned by the user is the following dict, for invoke function, data is bytes, for other apis, data is dict. | |||
README.md
Outdated
| resp = await client.invokeFunction(serviceName, funcName, null); | ||
| console.log('invoke function: %j', resp); | ||
|
|
||
| // respBuf is returned as buffer if isRawBuf is true | ||
| respBuf = await client.invokeFunction(serviceName, funcName, null, {}, 'LATEST', true); |
There was a problem hiding this comment.
这个叫respBuf不合适，invokeFunction的返回不是直接的一个Buffer，resp.data是Buffer
test/client.test.js
Outdated
| expect(func.data).to.have.property('functionName', functionWithHandledErr); | ||
|
|
||
| const response = await client.invokeFunction(serviceName, functionWithHandledErr, Buffer.from('world'), {}, 'LATEST', true); | ||
| expect(response.data).an(Object) |
| @@ -734,7 +804,8 @@ describe('client test', function () { | |||
| { | |||
| 'additionalVersionWeight': { | |||
| '2': 0.3 | |||
| } | |||
| }, | |||
| 'description': '' | |||
There was a problem hiding this comment.
之前的 case 过不了，看了代码，create alias 的时候 description 为 'test alias'，update 没有更新 description，expect description to be ' ' 是会 fail 的。
test/client.test.js
Outdated
| expect(func.data).to.have.property('functionName', functionWithUnhandledErr); | ||
|
|
||
| const response = await client.invokeFunction(serviceName, functionWithUnhandledErr, Buffer.from('world'), {}, 'LATEST', true); | ||
| expect(response.data).an(Object) |
There was a problem hiding this comment.
Unhandled error也要assert error message
README.md
Outdated
| resp = await client.invokeFunction(serviceName, funcName, null); | ||
| console.log('invoke function: %j', resp); | ||
|
|
||
| // respBuf is returned as buffer if isRawBuf is true | ||
| respBuf = await client.invokeFunction(serviceName, funcName, null, {}, 'LATEST', true); |
There was a problem hiding this comment.
最后一个参数是bool不太好，光看一个false/true不太清楚是什么含义，可以变成一个opts = {}，然后调用的时候变成：
respBuf = await client.invokeFunction(serviceName, funcName, null, {}, 'LATEST', {rawBuf: true});
CiCi503
force-pushed
the
add_raw_buffer_mode
branch
from
49829e2
to
f84e7d4
Compare
rockuw
reviewed
Nov 13, 2018
README.md
Outdated
| @@ -27,6 +27,10 @@ The response returned by the user is the following dict, for invoke function, da | |||
| } | |||
|
|
|||
| ``` | |||
| for invoke function, data is the results returned by your code. By default, data is decoded by utf8, if you would like to get raw buffer, just set {isRawBuf: true} in opts when you invoke function. | |||
CiCi503
force-pushed
the
add_raw_buffer_mode
branch
from
f84e7d4
to
864ad68
Compare
rockuw
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add raw buffer mode for invokeFunction