create and update function add runtime check

aliyun · Jan 18, 2018 · a70c5e8 · a70c5e8
1 parent 82cfbbc
commit a70c5e8
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/fc2/__init__.py b/fc2/__init__.py
@@ -6,7 +6,7 @@
 """
 
 __author__ = 'Aliyun Function Compute'
-__version__ = '2.0.2'
+__version__ = '2.0.4'
 
 from .client import Client
 from .fc_exceptions import FcError

diff --git a/fc2/client.py b/fc2/client.py
@@ -331,6 +331,9 @@ def create_function(
         """
         self._check_function_param_valid(codeZipFile, codeDir, codeOSSBucket, codeOSSObject)
 
+        if not isinstance(runtime, str):
+            raise Exception("runtime type must be string")
+
         method = 'POST'
         path = '/{0}/services/{1}/functions'.format(self.api_version, serviceName)
         headers = self._build_common_headers(method, path, headers)
@@ -403,6 +406,9 @@ def update_function(
             'timeout': 60,                // in second
         }
         """
+        if runtime and (not isinstance(runtime, str)):
+            raise Exception("runtime type must be string")
+
         method = 'PUT'
         path = '/{0}/services/{1}/functions/{2}'.format(self.api_version, serviceName, functionName)
         headers = self._build_common_headers(method, path, headers)

diff --git a/test/function_test.py b/test/function_test.py
@@ -109,6 +109,9 @@ def test_update(self):
         with self.assertRaises(fc2.FcError):
             self.client.update_function(self.serviceName, functionName, description='invalid', headers ={'if-match':'invalid etag'})
 
+        with self.assertRaises(Exception):
+            self.client.update_function(self.serviceName, functionName, codeZipFile='test/hello_world/hello_world.zip', runtime = 10)
+
         self.assertEqual(func['description'], desc)
 
         self.client.delete_function(self.serviceName, functionName)
@@ -290,6 +293,11 @@ def test_check_op_function_param_check(self):
                 self.serviceName, functionName,
                 handler='main.my_handler', runtime='python2.7', codeOSSBucket='test-bucket' ,  description=desc)
 
+        with self.assertRaises(Exception):
+            function = self.client.create_function(
+                self.serviceName, functionName,
+                handler='main.my_handler', runtime=10, codeZipFile='test/hello_world/hello_world.zip')
+
 
 if __name__ == '__main__':
     unittest.main()