add description to trigger #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rsonghuster
reviewed
Mar 19, 2019
fc2/client.py
Outdated
| @@ -739,13 +739,14 @@ def invoke_function(self, serviceName, functionName, payload=None, headers={}, q | |||
|
|
|||
| return FcHttpResponse(r.headers, r.content) | |||
|
|
|||
| def create_trigger(self, serviceName, functionName, triggerName, triggerType, triggerConfig, sourceArn, | |||
| def create_trigger(self, serviceName, functionName, triggerName, description, triggerType, triggerConfig, sourceArn, | |||
There was a problem hiding this comment.
description 这个参数最好放在最后面， 为了向下兼容， 并且让默认参数 = ""
rsonghuster
reviewed
Mar 20, 2019
fc2/client.py
Outdated
| @@ -794,13 +795,14 @@ def delete_trigger(self, serviceName, functionName, triggerName, headers={}): | |||
| headers = self._build_common_headers(method, path, headers) | |||
| self._do_request(method, path, headers) | |||
|
|
|||
| def update_trigger(self, serviceName, functionName, triggerName, triggerConfig=None, invocationRole=None, | |||
| def update_trigger(self, serviceName, functionName, triggerName, description=None, triggerConfig=None, invocationRole=None, | |||
rsonghuster
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add description to trigger