- testcase: Improve the unit of the test cases

aliyun · Jan 28, 2022 · 84f0a8c · 84f0a8c
1 parent bd0cdfc
commit 84f0a8c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/alicloud/resource_alicloud_cr_chart_namespace_test.go b/alicloud/resource_alicloud_cr_chart_namespace_test.go
@@ -347,10 +347,10 @@ func TestAccAlicloudCRChartNamespace_unit(t *testing.T) {
 	})
 	t.Run("DeleteMockAbnormal", func(t *testing.T) {
 		retryFlag := true
-		noRetryFlag := false
+		noRetryFlag := true
 		patches := gomonkey.ApplyMethod(reflect.TypeOf(&client.Client{}), "DoRequest", func(_ *client.Client, _ *string, _ *string, _ *string, _ *string, _ *string, _ map[string]interface{}, _ map[string]interface{}, _ *util.RuntimeOptions) (map[string]interface{}, error) {
 			if retryFlag {
-				// retry until the timeout comes
+				retryFlag = false
 				return responseMock["RetryError"]("Throttling")
 			} else if noRetryFlag {
 				noRetryFlag = false

diff --git a/alicloud/resource_alicloud_cr_chart_repository_test.go b/alicloud/resource_alicloud_cr_chart_repository_test.go
@@ -349,10 +349,10 @@ func TestAccAlicloudCRChartRepository_unit(t *testing.T) {
 	})
 	t.Run("DeleteMockAbnormal", func(t *testing.T) {
 		retryFlag := true
-		noRetryFlag := false
+		noRetryFlag := true
 		patches := gomonkey.ApplyMethod(reflect.TypeOf(&client.Client{}), "DoRequest", func(_ *client.Client, _ *string, _ *string, _ *string, _ *string, _ *string, _ map[string]interface{}, _ map[string]interface{}, _ *util.RuntimeOptions) (map[string]interface{}, error) {
 			if retryFlag {
-				// retry until the timeout comes
+				retryFlag = false
 				return responseMock["RetryError"]("Throttling")
 			} else if noRetryFlag {
 				noRetryFlag = false

diff --git a/alicloud/resource_alicloud_ecs_auto_snapshot_policy_attachment_test.go b/alicloud/resource_alicloud_ecs_auto_snapshot_policy_attachment_test.go
@@ -259,10 +259,10 @@ func TestAccAlicloudEcsAutoSnapshotPolicyAttachment_unit(t *testing.T) {
 	})
 	t.Run("DeleteMockAbnormal", func(t *testing.T) {
 		retryFlag := true
-		noRetryFlag := false
+		noRetryFlag := true
 		patches := gomonkey.ApplyMethod(reflect.TypeOf(&client.Client{}), "DoRequest", func(_ *client.Client, _ *string, _ *string, _ *string, _ *string, _ *string, _ map[string]interface{}, _ map[string]interface{}, _ *util.RuntimeOptions) (map[string]interface{}, error) {
 			if retryFlag {
-				// retry until the timeout comes
+				retryFlag = false
 				return responseMock["RetryError"]("Throttling")
 			} else if noRetryFlag {
 				noRetryFlag = false

diff --git a/alicloud/resource_alicloud_vpc_traffic_mirror_filter_egress_rule_test.go b/alicloud/resource_alicloud_vpc_traffic_mirror_filter_egress_rule_test.go
@@ -235,7 +235,7 @@ resource "alicloud_vpc_traffic_mirror_filter" "default" {
 }
 
 func TestAccAlicloudVPCTrafficMirrorFilterEgressRule_unit(t *testing.T) {
-	t.Parallel()
+	//t.Parallel()
 	p := Provider().(*schema.Provider).ResourcesMap
 	d, _ := schema.InternalMap(p["alicloud_vpc_traffic_mirror_filter_egress_rule"].Schema).Data(nil, nil)
 	dCreate, _ := schema.InternalMap(p["alicloud_vpc_traffic_mirror_filter_egress_rule"].Schema).Data(nil, nil)

diff --git a/alicloud/resource_alicloud_vpc_traffic_mirror_filter_ingress_rule_test.go b/alicloud/resource_alicloud_vpc_traffic_mirror_filter_ingress_rule_test.go
@@ -237,7 +237,7 @@ resource "alicloud_vpc_traffic_mirror_filter" "default" {
 }
 
 func TestAccAlicloudVPCTrafficMirrorFilterIngressRule_unit(t *testing.T) {
-	t.Parallel()
+	//t.Parallel()
 	p := Provider().(*schema.Provider).ResourcesMap
 	d, _ := schema.InternalMap(p["alicloud_vpc_traffic_mirror_filter_ingress_rule"].Schema).Data(nil, nil)
 	dCreate, _ := schema.InternalMap(p["alicloud_vpc_traffic_mirror_filter_ingress_rule"].Schema).Data(nil, nil)