resource/alicloud_vpc_ipv4_gateway: Adds new attribute resource_group_id, tags, create_time, ipv4_gateway_id, ipv4_gateway_route_table_id. #6163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChenHanZhang
force-pushed
the
AutoGenVpcIpv4Gateway
branch
4 times, most recently
from
6bf23e5
to
559e4c1
Compare
ChenHanZhang
commented
May 19, 2023
alicloud/service_alicloud_vpc_v2.go
Outdated
| return object, WrapErrorf(err, DefaultErrorMsg, id, action, AlibabaCloudSdkGoERROR) | ||
| } | ||
|
|
||
| v, err := jsonpath.Get("$", response) |
There was a problem hiding this comment.
如果直接取根节点，就不需要jsonpath取值，直接返回response即可
xiaozhu36
requested changes
May 19, 2023
| if v, ok := d.GetOk("ipv4_gateway_name"); ok { | ||
| request["Ipv4GatewayName"] = v | ||
| } | ||
| request["DryRun"] = d.Get("dry_run") |
| "resource_group_id": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Computed: true, |
There was a problem hiding this comment.
新增了哪些属性，修改了哪些属性，弃用了哪些属性，都应该在PR 的标题上体现出来
ChenHanZhang
force-pushed
the
AutoGenVpcIpv4Gateway
branch
from
87b7bfc
to
5763868
Compare
ChenHanZhang
changed the title
ChenHanZhang
force-pushed
the
AutoGenVpcIpv4Gateway
branch
from
5763868
to
5804d55
Compare
ChenHanZhang
force-pushed
the
AutoGenVpcIpv4Gateway
branch
from
5804d55
to
e8a0b9c
Compare
xiaozhu36
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d, Tags etc.