Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken build (branch_9_0_x and branch_9_5_x) #31

Open
gallardo opened this issue Oct 2, 2014 · 1 comment
Open

Broken build (branch_9_0_x and branch_9_5_x) #31

gallardo opened this issue Oct 2, 2014 · 1 comment

Comments

@gallardo
Copy link

gallardo commented Oct 2, 2014

If I build against opencms_version from ms_9_4_7 or branch_9_5_x (neither opencms-core tag build_9_0_1 nor branch branch_9_0_x do build), I get the error CmsConfigurableCollector is not abstract ...:

Against 9.4.7:

[...]/alkacon-oamp/com.alkacon.opencms.v8.comments/src/com/alkacon/opencms/v8/comments/CmsCommentsAccess.java:1019: error: incompatible types: Object cannot be converted to Entry<String,String[]>
            for (Map.Entry<String, String[]> entry : CmsRequestUtil.createParameterMap(req.getParameterMap()).entrySet()) {
                                                                                                                      ^
Note: [...]/alkacon-oamp/com.alkacon.opencms.v8.comments/src/com/alkacon/opencms/v8/comments/CmsCommentsAccess.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
1 error

Against 9.5.x:

[...]/alkacon-oamp/com.alkacon.opencms.commons/src/com/alkacon/opencms/commons/CmsConfigurableCollector.java:70: error: CmsConfigurableCollector is not abstract and does not override abstract method getResults(CmsObject,String,String,int) in I_CmsResourceCollector
public class CmsConfigurableCollector extends A_CmsResourceCollector {
       ^
1 error
10 warnings
@gallardo gallardo changed the title Broken build Broken build (branch_9_0_x and branch_9_5_x) Oct 2, 2014
@gallardo
Copy link
Author

gallardo commented Oct 6, 2014

The commit modifying I_CmsResourceCollector (and thus breaking alkacon-oamp) is the commit alkacon/opencms-core@d3344bc#diff-17 (2014-08-04), lives in the branch https://github.com/alkacon/opencms-core/tree/branch_9_5_x, and has not been tagged yet.

gallardo added a commit to gallardo/alkacon-oamp that referenced this issue Oct 6, 2014
See alkacon#31: `I_CmsResourceCollector` has been extended. There is no implementation yet for a new method.
gallardo added a commit to gallardo/alkacon-oamp that referenced this issue Oct 6, 2014
opencms-core has extended interface I_CmsResourceCollector with a new
method signature. This commit is a workaround to allow compiling the
outdated alkacon-oamp sources.
gallardo added a commit to gallardo/alkacon-oamp that referenced this issue Oct 6, 2014
opencms-core has extended interface I_CmsResourceCollector with a new
method signature. This commit is a workaround to allow compiling the
outdated alkacon-oamp sources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant