Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malfunctioning "invalid date" error message in structured document editor (since 9.0.1 up to 9.5.1) #240

Closed
amagnolo opened this issue Apr 8, 2014 · 5 comments

Comments

@amagnolo
Copy link

amagnolo commented Apr 8, 2014

In the structured document editor, if an invalid date is manually entered (not using the date picker), the error message is not visible when the mouse cursor is not hovering over the date field. Moreover, the "save" button is not disabled, so the user can save the document without realizing that the saved date will not be what he expected (it will silently remain with the value it had before opening the editor).

Sometimes, instead, the "save" button is disabled (as it should be) and it is not easy to understand that the problem lies in a wrong date.

I wasn't able to reliably reproduce the conditions when the "save" button gets disabled and when not; in either case, the "wrong date format" error message should be prominent and inhibit the "save" button.

@amagnolo
Copy link
Author

amagnolo commented Apr 9, 2014

steps to reproduce the bug:

  1. open a blog entry in the OpenCms 9.0.1 demo website
  2. manually change the date to something invalid, e.g. "11/11/2011" (it is invalid because it doesn't include the time)
  3. the "save" icons are disabled (correct)
  4. change any other form field (for example the title)
  5. the "save" button is now enabled, but if you click it, the date entered will be ignored and its value will remain the one it had before the edit

This bug may be related to the fact that the Date element in blog.xsd has a solrfield mapped in searchsettings.

@amagnolo
Copy link
Author

This bug is still present in OpenCms 9.5.0, you can see it using a blog entry in the demo site.
It is very annoying because users can't realize the problem until it's too late, and this is happening with every user that inputs dates by hand (rather than using the calendar widget).
The bug was verified with Firefox and Chrome, on Linux and Windows clients.

@gWestenberger
Copy link
Contributor

We changed date select widgets with invalid dates to be more visible in the upcoming OpenCms 9.5.1.

@amagnolo
Copy link
Author

amagnolo commented Mar 3, 2015

This bug is still present in 9.5.1.
It has actually got worse, you don't even need steps 3 and 4 above to reproduce it.
Just enter anything invalid in a date field and it will be happily ignored by the form.

@amagnolo amagnolo changed the title Malfunctioning "invalid date" error message in structured document editor (9.0.1) Malfunctioning "invalid date" error message in structured document editor (since 9.0.1 up to 9.5.1) Mar 3, 2015
@gWestenberger gWestenberger reopened this Jan 11, 2016
@gWestenberger
Copy link
Contributor

This should finally work correctly in the upcoming version 9.5.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants