Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<meta http-equiv="X-UA-Compatible" content="IE=edge" /> is wrapped in a JavaScript #344

Closed
bjornbak opened this issue Sep 15, 2015 · 3 comments

Comments

@bjornbak
Copy link

When I log into ADE I get the follow wrong html which prevents the JavaScript to executed:

<script type="text/javascript">
<!--
<meta http-equiv="X-UA-Compatible" content="IE=edge" />var CMS_NO_PERMUTATION_MESSAGE='Your browser version is not supported by OpenCms. Please switch to a current version. ';

//-->
</script>

It is easily solved by this patch:

Index: src/org/opencms/gwt/CmsGwtActionElement.java
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
--- src/org/opencms/gwt/CmsGwtActionElement.java    (revision 2b71bf17c675815c39148ed817442c3be66d4479)
+++ src/org/opencms/gwt/CmsGwtActionElement.java    (revision )
@@ -222,8 +222,6 @@
             wpLocale = Locale.ENGLISH.getLanguage();
         }
         StringBuffer sb = new StringBuffer();
-        // append meta tag to set the IE to standard document mode
-        sb.append("<meta http-equiv=\"X-UA-Compatible\" content=\"IE=edge\" />");

         // print out the missing permutation message to be used from the nocache.js generated by custom linker
         // see org.opencms.gwt.linker.CmsIFrameLinker
@@ -231,6 +229,10 @@
             Messages.get().getBundle(OpenCms.getWorkplaceManager().getWorkplaceLocale(getCmsObject())).key(
                 Messages.ERR_NO_PERMUTATION_AVAILABLE_0)).append("';\n");
         wrapScript(sb);
+
+        // append meta tag to set the IE to standard document mode
+        sb.append("<meta http-equiv=\"X-UA-Compatible\" content=\"IE=edge\" />");
+
         String prefetchedData = exportDictionary(
             CmsCoreData.DICT_NAME,
             I_CmsCoreService.class.getMethod("prefetch"),
@tHerrmann
Copy link

We have fixed this issue with commit 44e5572 in branch_9_5_x.

@bjornbak
Copy link
Author

What are the plans for a 9.5.3 with this and other fixes?

@tHerrmann
Copy link

We are planing a to release a version 9.5.3, but the date is not set yet. We will probably announce the schedule at the upcoming OpenCms Days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants