Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG+1] Exogenous -> X #385

Merged
merged 4 commits into from
Sep 9, 2020
Merged

[MRG+1] Exogenous -> X #385

merged 4 commits into from
Sep 9, 2020

Conversation

tgsmith61591
Copy link
Member

This replaces the exogenous keyword with X. For more information on this, see #372. Note that the exogenous keyword will still work with a DeprecationWarning until version 2.0

@tgsmith61591 tgsmith61591 changed the title [WIP] Exogenous -> X [MRG] Exogenous -> X Sep 9, 2020
aaronreidsmith
aaronreidsmith approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@aaronreidsmith aaronreidsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things, but LGTM overall! 🎉

pmdarima/model_selection/_split.py Outdated Show resolved Hide resolved
pmdarima/model_selection/_validation.py Outdated Show resolved Hide resolved
pmdarima/arima/arima.py Outdated Show resolved Hide resolved
examples/preprocessing/example_date_featurizer.py Show resolved Hide resolved
@aaronreidsmith aaronreidsmith changed the title [MRG] Exogenous -> X [MRG+1] Exogenous -> X Sep 9, 2020
@tgsmith61591 tgsmith61591 merged commit d667820 into master Sep 9, 2020
@tgsmith61591 tgsmith61591 deleted the exog-to-x branch September 9, 2020 13:23
@tgsmith61591 tgsmith61591 mentioned this pull request Mar 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronreidsmith aaronreidsmith aaronreidsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgsmith61591 @aaronreidsmith