VC Edit Profile #6273
VC Edit Profile #6273
Conversation
| @@ -13,11 +17,31 @@ export const VCSettingsPage = () => { | |||
| }, | |||
| }); | |||
|
|
|||
| const [updateContributorMutation] = useUpdateVirtualContributorMutation(); | |||
|
|
|||
| const handleUpdate = async virtualContributor => { | |||
There was a problem hiding this comment.
I would just call the function here, there's no need to await if you're not doing anything after
| if (loading) return <Loading text={'Loading Virtual Contributor Settings ...'} />; | ||
|
|
||
| // TODO: StorageProvider for the VC |
There was a problem hiding this comment.
Normally we just use the platform StorageProvider for entities that we are creating (which is definitely wrong, but it is a solution if you need it now),
or hide the ReferencesSegment in the Create form and show it in the edit form. Which is also bad but I think it's better better.
| }; | ||
|
|
||
| const validationSchema = yup.object().shape({ | ||
| name: nameSegmentSchema.fields?.name || yup.string(), |
There was a problem hiding this comment.
probably copied from somewhere else but please use ?? for nullish coalescing
|
|
||
| const HostFields = () => ( | ||
| <> | ||
| <FormikInputField name={'host'} title={'Host'} required readOnly disabled /> |
There was a problem hiding this comment.
please use double quotes here instead of {'host'} ...
All if this is temporary, right? can you add a comment?
|
|
||
| const [handleSubmit, loading] = useLoadingState(async (values: VirtualContributorFromProps) => { | ||
| const { tagsets, description, tagline, name, ...otherData } = values; | ||
| const updatedTagsets = getUpdatedTagsets(tagsets || []); |
| description, | ||
| tagline, | ||
| tagsets: updatedTagsets.map(r => ({ | ||
| ID: r.id, |
There was a problem hiding this comment.
is this id: undefined required? you're creating a new object...
also I would call the variable tagset
There was a problem hiding this comment.
I'm displaying the tagsets, there's no default tagset. I could use some help on switching from default keywords and capabilities to just tags.
| const result: UpdateTagset[] = []; | ||
| updatedTagsets.forEach(updatedTagset => { | ||
| const originalTagset = tagsets?.find(value => value.name === updatedTagset.name); | ||
| if (originalTagset) result.push({ ...originalTagset, tags: updatedTagset.tags }); |
There was a problem hiding this comment.
please use curly brackets here
#5911