refactor of roles service to allow separately querying journey roles from org roles #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from organization roles
valentinyanakiev
requested review from
hero101
and removed request for
valentinyanakiev
hero101
requested changes
Sep 1, 2023
There was a problem hiding this comment.
I see a lot of async/await in your code that are not required.
You can think of the await basically as execution. It should only be used if you need the value right now, in your next line, otherwise, you just pass around the promise.
Overall the implementations look good. An additional optimization leveraged by resolvers.
src/services/api/roles/util/get.organization.roles.for.user.entity.data.ts
Outdated
Show resolved
Hide resolved
hero101
reviewed
Sep 1, 2023
hero101
previously approved these changes
Sep 1, 2023
hero101
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rational for this PR is that the userRoles query always was getting both all journey roles and all organization roles - regardless of what fields were being requested. And in the latest update from Andrew the code does request the different roles separately - which leads to an inefficient api.
The graphql api has not changed, this is a pure internal optimization that is important to allow client querying of organizational roles to be fast - currently it is still getting all the journey roles in the business logic.
Design:
Important is that the logic path for organization roles is now fully independent of that of journey roles, as they are different (space visibilities etc makes no sense on organization roles).