Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added type for whiteboard content #3203

Merged
merged 4 commits into from
Sep 18, 2023
Merged

added type for whiteboard content #3203

merged 4 commits into from
Sep 18, 2023

Conversation

techsmyth
Copy link
Member

Used on all DTOs, fields where whiteboard content is being handled.

hero101
hero101 requested changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@hero101 hero101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also believe the new scalar must be included in the codegen.yml of the client.

src/domain/common/scalars/scalar.whiteboard.content.ts Outdated Show resolved Hide resolved
src/domain/common/scalars/scalar.whiteboard.content.ts Outdated Show resolved Hide resolved
@hero101 hero101 merged commit 136d837 into develop Sep 18, 2023
2 checks passed
@hero101 hero101 deleted the server-3188 branch September 18, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@me-andre me-andre me-andre approved these changes

@hero101 hero101 hero101 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@techsmyth @me-andre @hero101