Cleaning up

src/app.ts

@@ -3,12 +3,10 @@ import { getTotalScores } from './domain/game-score-manager';
 import { initHand } from './domain/game-service';
 import { playerExtractor } from './service/auth-middleware';
 import { PlayerRequest } from './service/player-request';
-import { sendRecoverySms } from './service/sms-recovery-service';
 import { tokenForLoginId } from './service/token-service';
 import { Card } from './types/card';
 import { GameTypeChoice } from './types/game-type-choice';
 import { RegisterPlayer } from './types/register-player';
-import { SmsRecovery } from './types/sms-recovery';
 import { TrickResponse } from './types/trick-response';
 import cors from 'cors';
 import * as dotenv from 'dotenv';
@@ -218,17 +216,6 @@ router.get(
   }
 );
 
-router.post('/sms-recovery', (req: express.Request, res: express.Response) => {
-  const smsRecovery = req.body as SmsRecovery;
-  sendRecoverySms(smsRecovery)
-    .then(() => {
-      res.sendStatus(StatusCodes.NO_CONTENT);
-    })
-    .catch((err) => {
-      res.status(StatusCodes.BAD_REQUEST).send({ error: err.message });
-    });
-});
-
 wss.on('connection', (ws: WebSocketWithGameId, req: Request) => {
   console.log('Client connected');
 

src/bismarck-web/src/components/Create.tsx

@@ -72,7 +72,7 @@ export const Create = () => {
           name="tab-group"
           type="radio"
           onClick={removePlayer}
-          checked
+          defaultChecked
         />
         <input
           id="four-players"

src/bismarck-web/src/index.css

@@ -48,7 +48,6 @@ button,
 input[type='submit'],
 input[type='button'] {
   border-radius: 5px;
-  box-shadow: var(--shadow-color) 0 0 2rem;
   color: var(--whitelike);
   border: 0;
   outline: none;

src/domain/game-creation-service.ts

@@ -9,7 +9,6 @@ import {
   storeGame,
   storeHandStatute,
   storeLoginIdForPlayer,
-  storeSmsRecoveries,
 } from '../persistence/storage-service';
 
 const initGameObject = (players: RegisterPlayer[]): Game => {
@@ -74,17 +73,6 @@ export const createGameAndInvitatePlayers = async (
 
   storeHandStatute(handStatute, gameId);
 
-  storeSmsRecoveries(
-    [...playerIds.entries()].map((x) => {
-      return {
-        player: x[1].player,
-        canSendRecovery: true,
-        loginId: x[0],
-      };
-    }),
-    gameId
-  );
-
   return {
     id: gameId,
     game,

src/domain/hand-service.ts

@@ -125,7 +125,7 @@ const playerHasCardsOfSuit = (
   return playersCards.some((card) => getSuit(card) === trickSuit);
 };
 
-export const setUpHand = async (gameId: string, game: Game) => {
+export const setUpHand = async (gameId: string, game: Game): Promise<void> => {
   initDeck(gameId);
 
   const handStatute = getHandStatute(game, await getTrumpSuit(gameId));

src/persistence/storage-service.ts

@@ -1,6 +1,5 @@
 import { CardContainer } from './card-container';
 import { GamePlayer } from './game-player';
-import { PlayerSmsRecovery } from './player-sms-recovery';
 import { Trick } from './trick';
 import { Game } from '../types/game';
 import { HandStatute } from '../types/hand-statute';
@@ -15,8 +14,7 @@ type StorageType =
   | Trick
   | Game
   | TrickScore[]
-  | GamePlayer
-  | PlayerSmsRecovery[];
+  | GamePlayer;
 
 const ONE_DAY_EXPIRATION = 86400;
 
@@ -51,9 +49,6 @@ const getTrickScoresKey = (identifier: string): string =>
 const getPlayerLoginIdKey = (identifier: string): string =>
   `gameplayer:${identifier}`;
 
-const getSmsRecoveryKey = (identifier: string): string =>
-  `smsrecovery:${identifier}`;
-
 export const storeGame = (game: Game, identifier: string): void => {
   store(getGamesKey(identifier), game);
 };
@@ -145,17 +140,3 @@ export const fetchPlayerWithLoginId = async (
   const result = await fetch(getPlayerLoginIdKey(loginId));
   return JSON.parse(result);
 };
-
-export const storeSmsRecoveries = (
-  smsRecoveries: PlayerSmsRecovery[],
-  identifier: string
-): void => {
-  store(getSmsRecoveryKey(identifier), smsRecoveries);
-};
-
-export const fetchSmsRecoveries = async (
-  identifier: string
-): Promise<PlayerSmsRecovery[]> => {
-  const result = await fetch(getSmsRecoveryKey(identifier));
-  return JSON.parse(result);
-};