fix: allow hypens for username matching in parseComment #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakebolam
approved these changes
Apr 28, 2020
|
It's bizarre that the release bot hasn't commented on this PR. Edit: It seems that CircleCI is returning errors, https://app.circleci.com/pipelines/github/all-contributors/all-contributors-bot (e.g. "An error occurred on client"). |
|
@jakebolam @gr2m Does this PR shows up on CircleCI on your sides? I can't seem to even see it and all-contributors-bot is locked on there and I can't change that. |
|
Just wanted to mention I just had the probem today, contributor's username was a-mere-peasant. |
|
🎉 This PR is included in version 1.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This was referenced Sep 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for both all-contributors/cli#225 (comment) and #292 both issues relating to hyphens being discarded in the
parseComment()function by the following normalise option:So as an alternative, we set this to
trueand get rid of the whitespace with.replace(/\s/g, '').