Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(repo): github profile url should be valid #268

Merged
merged 2 commits into from
Jun 7, 2020
Merged

feat(repo): github profile url should be valid #268

merged 2 commits into from
Jun 7, 2020

Conversation

k3nsei
Copy link
Contributor

@k3nsei k3nsei commented Jun 7, 2020 •
edited

What:
Contributor profile url should be valid url

Why:
Please see issue #267

How:
Validator was added and used where github profile url is assigned

Checklist:

  • [N/A] Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@k3nsei
Copy link
Contributor Author

k3nsei commented Jun 7, 2020

@Berkmann18 please do code review

@Berkmann18 Berkmann18 linked an issue Jun 7, 2020 that may be closed by this pull request
Contributor profile url need to be validated #267
Closed
@Berkmann18 Berkmann18 self-assigned this Jun 7, 2020
Berkmann18
Berkmann18 approved these changes Jun 7, 2020
View reviewed changes
Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me. Have you tried that on your repo where you originally had the issue?

@k3nsei
Copy link
Contributor Author

k3nsei commented Jun 7, 2020 •
edited 

yarn run all-contributors add Silvest89 bug
yarn run v1.22.4
$ /app/projects/ng-in-viewport/node_modules/.bin/all-contributors add Silvest89 bug
Cannot read property 'isValidHttpUrl' of undefined
error Command failed with exit code 1.

Don't know why const util = require('../util') doesn't work and returns empty object.

@k3nsei
Copy link
Contributor Author

k3nsei commented Jun 7, 2020

@Berkmann18 I changed import from const util = require('../util') to const utilUrl = require('../util/url') and now everything works as expected.

Berkmann18
Berkmann18 requested changes Jun 7, 2020
View reviewed changes
src/repo/github.js Outdated Show resolved Hide resolved
src/repo/github.js Outdated Show resolved Hide resolved
@k3nsei
Copy link
Contributor Author

k3nsei commented Jun 7, 2020

@Berkmann18 now all should be ok

@Berkmann18 Berkmann18 merged commit b77f86b into all-contributors:master Jun 7, 2020
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@k3nsei k3nsei deleted the feature/validate-profile-url branch June 7, 2020 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Berkmann18 Berkmann18 Berkmann18 approved these changes

Assignees

@Berkmann18 Berkmann18

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contributor profile url need to be validated
3 participants
@k3nsei @all-contributors-release-bot @Berkmann18