Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: badge is not updated automatically #314

Closed
Belco90 opened this issue Oct 18, 2019 · 15 comments
Closed

Question: badge is not updated automatically #314

Belco90 opened this issue Oct 18, 2019 · 15 comments

Comments

@Belco90
Copy link

Belco90 commented Oct 18, 2019

I don't think this is exactly a bug (as I see this working fine in other projects), but I can't get the "all contributors" badge automatically updated properly in my repo, so I guess something is wrong in my config but I can't find what is it.

This is my repo. I set it up first with the CLI and then switched to the bot, I don't know if that could affect the badge but the bot modified some stuff added from the CLI so I assumed everything was fine. I have checked the docs and the only thing I can find related to the badge is the config to customize the template, but I suppose I don't need to set that.

Can you help me with this? Thanks :)

@Berkmann18
Copy link
Member

When you set the configuration (read the .all-contributorsrc file), did you replied yes to the badge update question?

@Belco90
Copy link
Author

Belco90 commented Oct 21, 2019

Sure! That added the badge automatically for me actually.

@Berkmann18
Copy link
Member

Did it got updated since?

@Belco90
Copy link
Author

Belco90 commented Oct 21, 2019

Not really: it started at 0 and I updated manually at some point after adding some contributors and not getting the badge automatically updated.

@Belco90
Copy link
Author

Belco90 commented Oct 24, 2019

Here you have an example: https://github.com/Belco90/eslint-plugin-testing-library/pull/33/files

You can see it's adding a new contributor but not updating the badge.

@jonastg
Copy link

jonastg commented Oct 30, 2019

Also included with CLI, if I remove the comments <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section --> and <!-- ALL-CONTRIBUTORS-BADGE:END --> it doesn't update the badge number, but if I keep the comment, the badge appears broken on Github and it show the text

@Berkmann18
Copy link
Member

@Belco90 @jonastg Does that happen only with the latest CLI version?

@jonastg
Copy link

jonastg commented Nov 3, 2019

@Berkmann18 First time using all-contributors, installed "all-contributors-cli": "^6.9.3"

@samajammin
Copy link

Our project is also having this issue. I followed your docs to set it up & have used the bot from the start. I've been manually updating the badge occasionally but am planning to remove it for now.

Any idea what might be causing this? I tried adding the badgeTemplate option but that didn't fix it.

(Great project BTW! Loving it aside from this issue)

@Berkmann18
Copy link
Member

@samajammin Hmm, I'm really not sure of what is causing this.
Perhaps the others from @all-contributors/core may know more about that.

@Andre601
Copy link

I can confirm that this bug exist.
I also had the bot make a PR which had the .all-contributorsrc file created and at a later point added another user, but the bot didn't update the badge, so I had to manually update it.
What solutions/ideas do you guys have?

I saw that you need <!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section --> and <!-- ALL-CONTRIBUTORS-BADGE:END--> around the badge?
Can I set this on the same line because I want to have multiple badges on the same line.

@all-contributors all-contributors deleted a comment from allcontributors bot Nov 23, 2019
@Berkmann18
Copy link
Member

As far as I can tell, the bot doesn't use an up-to-date version of the CLI which I've noticed when the Markdown placeholder comments in the README differ when the CLI generated the table from when it's the bot which does it.

The issue might lie on the CLI but based on the above comments it seems to be more on the bot' side.

@jakebolam
Copy link
Collaborator

Hey yall.

We recently rolled out a fix for this, we've documented the steps need (i.e. need the tags now) here: https://allcontributors.org/docs/en/bot/faq#all-contributors-badge-count-does-not-update

@Andre601
Copy link

Andre601 commented Dec 10, 2019

Can this also be made like this, when you set the style to [badge]: <link>?

<!-- ALL-CONTRIBUTORS-BADGE:START - Do not remove or modify this section -->
[badge]: https://img.shields.io/badge/all_contributors-13-orange.svg?style=flat-square
<!-- ALL-CONTRIBUTORS-BADGE:END -->

[![badge]](#contributors)

I want to have the links for badges and sites in one place to easier maintain it.

@jakebolam
Copy link
Collaborator

jakebolam commented Dec 10, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants