-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding "data" emoji for collected data #334
Comments
I see where you're coming from. |
It's not necessary to change the description of Suggested emoji: 🔣 to be fair to all the kind of data or 💾 for the good ol' days! |
🔣 seems representative of that. @all-contributors/core What do y'all think? |
@Berkmann18 I can work on a PR in the upcoming days! |
@smoia That would be amazing (don't forget there are 3 repos to update for changes like this ;)). |
@Berkmann18 Ok, I just noticed it. I'm going to use your project manager PRs (e.g. #141 ) as a model . |
@Berkmann18 sorry to bother you, but I'm trying to add the emojis in the files. I'm typing it in, but that's not enough? How do you add the emoji inside the md file other than :code: ? |
@smoia You may need to copy-paste it from GH or any place that have the emoji icon. |
I did - still getting the expression itself rather than the emoji. |
@Berkmann18 managed! I had to manually enter the unicode equivalent. |
Second PR ready - should I wait for a new tag/release of all-contributors before modifying the all-contributors-bot? |
I'm glad to see that you managed to do it. That way, you already have the core of the bot PR ready to reviewed (even tho GH disables reviews for draft PRs) without having to wait. |
Oh ok, I see. |
@smoia For the CLI/spec repo, no need.
You could wait, however, I think it would be better to already have a (draft) PR submitted so you just need to commit the version change. Alternatively, you can set it up locally and push the PR once the release comes in. |
@Berkmann18 last PR ready, tested and corrected. After that, I'd say we close this issue! I have a question though: I already started to use the "data" emoji adding it manually in my contributors table. I guess the bot will pick it up without any problem, right? |
@smoia It won't pick it up when you tell it to add a data contribution (unless you mean the test bot you set up with your changes) until the code is pushed and deployed. |
I see - yes, obviously the code has to be merged first. I'll wait and see! |
Is your feature request related to a problem? Please describe.
I discovered all-contributors thanks to tedana, a package for neuroimaging data analysis. I'm trying to implement it for phys2bids, another package for neuroimaging related data handling.
I hope this is not too similar to #63 , but the thing is that "content" as specified now doesn't seem to cover those people who collect data and contribute to a project in that way.
Also, it might be useful to distinguish between data for testing and data for "consumption".
Describe the solution you'd like
It would be nice to either update the definition of "content" contributors, or to add a new entry for "data" contributor (that doesn't seem too bounded to text production).
Describe alternatives you've considered
Additional context
It would even be better to have two entries, one for generic "data" and one for "data for tests".
The text was updated successfully, but these errors were encountered: