Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(processIssueComment): added 'data' contributors #288

Merged
merged 4 commits into from
Apr 28, 2020
Merged

feat(processIssueComment): added 'data' contributors #288

merged 4 commits into from
Apr 28, 2020

Conversation

smoia
Copy link
Contributor

@smoia smoia commented Jan 3, 2020

Implements the "Data" category from all-contributors/all-contributors#336
and all-contributors/cli#231.

Cfr. all-contributors/all-contributors#334.

Using #166 as model.

@smoia smoia requested a review from Berkmann18 February 5, 2020 15:27
@smoia
Copy link
Contributor Author

smoia commented Feb 5, 2020

Hi all, any update on this? Do I need to do something more? I can't wait to use the bot for this contribution type!

Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Edit: hmm, I still don't have write access on this repo :s.

@smoia smoia requested a review from jakebolam February 6, 2020 15:27
@smoia
Copy link
Contributor Author

smoia commented Mar 20, 2020

Hi there!
Any update on this PR? I'd love to use it!

@Berkmann18
Copy link
Member

Only someone in @all-contributors/core who has write permissions (so not me) would be able to approve this.

@jakebolam
Copy link
Contributor

Thank you @smoia

@jakebolam jakebolam merged commit 68d2cb9 into all-contributors:master Apr 28, 2020
@smoia
Copy link
Contributor Author

smoia commented Apr 28, 2020

Thank you @jakebolam for merging it in!
@Berkmann18 I think we can close also the original issue all-contributors/all-contributors#334!
is there any other step to do, or everything is done now?

@smoia smoia deleted the data_contributor branch April 28, 2020 15:51
@Berkmann18
Copy link
Member

@smoia Yup.

@github-actions
Copy link

github-actions bot commented Jan 1, 2021

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants