docs: more info on translating #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Berkmann18
reviewed
Feb 5, 2019
|
Is that inline with what needs to be done to resolve #159 or is it separate? |
|
@Berkmann18 I think it's ok to have multiple PRs for an issue. This change is totally not complete (just didn't want to lose the context I had when translating) |
|
@jakebolam Okay, I'll try to draft something either tomorrow or sometime this week (as tomorrow is forecasted to be busy). |
Added an URL for those who might not know what _XPATH_ is and more context around what could be translated
Berkmann18
reviewed
Feb 8, 2019
| > When translating, its important that anything that has the [XPATH](https://developer.mozilla.org/en-US/docs/Web/XPath) `@href`, `@src` etc should not be translated. Things like `code` should not be either. This will cause the project to 404. See below image for an example: | ||
| <img src="../../assets/translating-xpath.png" alt="Contribute to translating" /> | ||
|
|
||
| > However, it's recommended to translate any content that would contribute to a better comprehension like the comments in `code` tags _as long as_ it doesn't change the actual code since it only understands English. |
There was a problem hiding this comment.
@jakebolam What do you think about that?
|
🎉 This PR is included in version 2.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #159.