Fix sentence location in README.md #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed sentence location in the README.md file.
Added myself as a contributor.
kentcdodds
approved these changes
Jan 21, 2017
jakebolam
added a commit
that referenced
this pull request
Feb 4, 2019
jakebolam
added a commit
that referenced
this pull request
Feb 4, 2019
* Initial commit * Update README.md * first commit * docs: add ci badge * docs: add license * infra: use nvm locally * ci: correct deploy key * docs: all contributors * docs: badge space * ci: fix cache key * docs: contributing * ci: fix working dir * ci: website build path * docs: arrange badges * docs: all contributors specification * docs: badge not flat square * docs: switch to all-contributors org (#1) * docs: update all-contributors link * docs: switch org * docs: chat on slack * docs: use google analytics * feat: add branding (#3) * docs: update all-contributors link * feat: add branding * docs: add tbenning as a contributor (#4) * docs: update README.md * docs: update .all-contributorsrc * docs: say hello to @all-contributors bot * docs: links & grammar * docs: sync with master repo (drops atom plugin recommendation) * docs: add Greenkeeper badge 🌴 (#5) * docs(readme): add Greenkeeper badge * Update README.md * docs(overview): added new maintenance category (#6) This goes hand in hand with [all-contributors-cli#142](all-contributors/cli#142). * docs: document bot and cli tools (#8) * docs: update all-contributors link * docs: wip * docs: tweaks * new homepage * docs: wip * docs: first pass * docs: tweaks * docs: fix some grammar (#13) * docs: grammar tweaks * docs: use github star button * docs: the problem section for CLI * docs: cli docs * docs: wording on motivation * docs: description wrong * docs: enable search * docs: update contributing with search * chore: added commitizen (#9) * chore(package): added commitizen * docs(readme): added the cz badge * chore(yarn): updated yarn.lock * chore: removed all-contributors-cli * feat: add translations (#14) * translation: first pass * translation: first pass * brew * docs: add translations * infra: write translations in ci * infra: drop ci for branches * valid * docs: add Jongjineee as a contributor (#18) * docs: update README.md * docs: update .all-contributorsrc * docs: add robertlluberes as a contributor (#19) * docs: update README.md * docs: update .all-contributorsrc * docs(emoji-key): added missing `business` and `content` (#20) * docs(emoji-key): added missing `business` and `content` I added the missing types and removed the uneeded `npx` call in the `commit` NPM script. * docs(emoji-key): removed 'N/I' line * docs: switch to Portuguese, Brazilian * docs: switch to Portuguese, Brazilian * docs: enable chinese simplified zh-CN * docs: enable chinese simplified zh-CN * docs: add Berkmann18 as a contributor (#21) * docs: update README.md * docs: update .all-contributorsrc * docs: update README.md * docs: update .all-contributorsrc * docs: add MarsXue as a contributor (#22) * docs: update README.md * docs: update .all-contributorsrc * docs: update README.md * docs: update .all-contributorsrc * docs: add MatheusRC as a contributor (#25) * docs: update README.md * docs: update .all-contributorsrc * Revert "docs: add MatheusRC as a contributor (#25)" (#26) This reverts commit b20eae0. * docs: add MatheusRV as a contributor (#27) * docs: update README.md * docs: update .all-contributorsrc * docs: update README.md * docs: update .all-contributorsrc * doc: doc fix (#24) * docs(emoji-key): added missing `business` and `content` I added the missing types and removed the uneeded `npx` call in the `commit` NPM script. * docs: improvements and fixes Made some bits more comprehensible and fixed some typos * infra: fix ci * feat: support translations, drop example files * docs(cli-usage): use inline code to specify the command "generate" (#28) * docs: add MarsXue as a contributor (#29) * docs: update README.md * docs: update .all-contributorsrc * docs: add Berkmann18 as a contributor (#31) * docs: update README.md * docs: update .all-contributorsrc * docs: add greenkeeper as a contributor (#32) * docs: update README.md * docs: update .all-contributorsrc * docs: add allcontributors as a contributor (#33) * docs: update README.md * docs: update .all-contributorsrc * docs: add root pages for languages * docs: remove greenkeeper (#36) * docs: add Greenkeeper[bot] as a contributor (#37) * docs: update README.md * docs: update .all-contributorsrc * feat: new homepage (#15) * Added HTML structure for the Index page. * added base styles, css variables, and a grid. Modified some of the HTML. * changed a few css rules * added normalize, continued styling * added image files, continued styling, modified some of the copy for how to * fixed the wavey background css * started adding media queries fixing styling issues * More css tweaks and adjustments * couple more styling tweaks, making it responsive * fixed some flexbox issues. made it more responsive * feat: add github badge button * styled the added the github stars widget to live in the nav and float in mobile * added the icons and styled them for the quick links * added logos and some styling, might need a last pass on the styles * changed some copy on buttons, made links open in new tab * fixing last responsive details on user logos * wip * feat: missing files + open graph data * fix: switch styles over to main.css * fix: site name * fixed the issues that the docs css was creating, should be good to go on mobile responsiveness (#43) docs :fixing CSS * feat: add 404 page (#44) * fixed the issues that the docs css was creating, should be good to go on mobile responsiveness * created a 404 page * added in / for 404 page * docs: fix link in 404 page (#45) * docs: add maryampaz as a contributor (#46) * docs: update README.md * docs: update .all-contributorsrc * feat: add analytics tracking to root pages, and 404s (#47) * docs: hawaii banner for conference (#50) * feat: link to jsconfhi * infra: add 404 check for CI (#52) * infra: add 404 check for CI * ci * background * sleep less * check 404s only after release * infra: smart sleep * infra: smart sleep * formik 404 * docs: locallized badge * docs: switch badge around * docs: link to build workflow * docs: few fixes and tweaks (#54) * aloha, remove use of h1 * docs: move over docs, style footer * docs: typo fixes (#53) * docs(emoji-key): added missing `business` and `content` I added the missing types and removed the uneeded `npx` call in the `commit` NPM script. * docs: improvements and fixes Made some bits more comprehensible and fixed some typos * docs(repository-maintainers): fixed minor typo * docs(bot): fixed a typo Fixed the typo in the _overview_ page to the _usage_ one * docs: fix readme * website uses allcontributrs.org * build * lock file and checkout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed sentence location in the README.md file.