docs: add olets as a contributor for doc #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![allcontributors[bot]](https://avatars.githubusercontent.com/in/23186?s=60&v=4){kind=small}
3 tasks
|
@olets Are you okay with this? |
olets
suggested changes
Jan 5, 2023
.all-contributorsrc
Outdated
| "login": "olets", | ||
| "name": "Henry Bley-Vroman", | ||
| "avatar_url": "https://avatars.githubusercontent.com/u/3282350?v=4", | ||
| "profile": "http://olets.dev", |
There was a problem hiding this comment.
Can we change this to https, here and in the README? Lmk if I can help.
Wonder if that's a GitHub thing or an all-contributors thing. In my profile I had no protocol
I've updated my profile to add https:// so closing this PR and making a new one should be one way of making the change.
There was a problem hiding this comment.
That's pulled from GH's API. If that's the only change you made, then I can simply rectify it on this PR.
There was a problem hiding this comment.
Good to know! http must be GitHub's default for that
Yep that's the only change
gr2m
reviewed
May 12, 2023
gr2m
approved these changes
May 12, 2023
|
🎉 This PR is included in version 2.17.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds @olets as a contributor for doc.
This was requested by Berkmann18 in this comment
[skip ci]