Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Add Contributor #198

Closed
teamcoltra opened this issue Apr 25, 2019 · 4 comments
Closed

Cannot Add Contributor #198

teamcoltra opened this issue Apr 25, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@teamcoltra
Copy link

Describe the bug
I'm a maintainer on a project but not the owner I don't know if that makes a difference, but I write the standard "@all-contributors please add for code" and it just says "We had trouble processing your request. Please try again later."

Expected behavior
A pull request made to add contributions

I am not sure what the specific error is because the bot isn't giving me an actionable error message.

@teamcoltra teamcoltra added the bug Something isn't working label Apr 25, 2019
@sinchang
Copy link
Contributor

you missed contributor GitHub id.

@teamcoltra
Copy link
Author

@sinchang sorry my bug report left it out because I just used > username < as a placeholder

Well I just had a thought and deleted my .all-contributorsrc which was the following:

{
  "files": ["README.md","CONTRIBUTORS.md"],
  "imageSize": 100,
  "contributorsPerLine": 7,
  "badgeTemplate": "[![All Contributors](https://img.shields.io/badge/all_contributors-<%= contributors.length %>-orange.svg?style=flat-square)](#contributors)",
  "contributorTemplate": "<%= avatarBlock %><br /><%= contributions %>",
  "contributors": []
} 

and then it started working. This was just pulled from the example with the addition of the "CONTRIBUTORS.md" file. Not sure what in there broke it, but I would say that the bigger bug here is it not telling me what actually went wrong.

@Berkmann18
Copy link
Member

@teamcoltra Well, normally the bot should comment when it doesn't understand a query addressed to it.

@jakebolam
Copy link
Contributor

Thanks for reporting this @teamcoltra. We should totally work on surfacing our error messages better.

I believe this was caused because of #201, and I've now ticketed it thanks, PRs welcome 😀

Summary:

The bot currently decides whether to 'init' (install the placeholders for the table and badge) for the README if there is no .all-contributorsrc file. If the file is found, it skips this step. This causes the bot to crash if a user has an .all-contributorsrc file but has nothing else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants