feat(contribution-types): support plural forms, multi word types and any case #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=======================================
Coverage 59.57% 59.57%
=======================================
Files 4 4
Lines 94 94
Branches 12 12
=======================================
Hits 56 56
Misses 33 33
Partials 5 5Continue to review full report at Codecov.
|
jakebolam
changed the title
…s/all-contributors-bot into feature/support-plurarls
jakebolam
commented
Jan 17, 2019
| usertesting: 'userTesting', | ||
| } | ||
|
|
||
| // Additional terms to match to types (plurals, aliases etc) |
There was a problem hiding this comment.
I investigated using compromise for plurals and it fell quite short (got 15 of our needed 21) also missed some plural forms.
|
I like that 😄 ! |
|
@Berkmann18 you good if I merge this? |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #15.
Alternative approach to #37