Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contributor cards in second row and onwards are not in bold #54

Closed
revelt opened this issue Nov 2, 2017 · 3 comments
Closed

contributor cards in second row and onwards are not in bold #54

revelt opened this issue Nov 2, 2017 · 3 comments

Comments

@revelt
Copy link
Contributor

revelt commented Nov 2, 2017

Hi all,

Currently only the first row is in bold:

bold-not-bold

If we added double asterisks on every card's label on second row and onwards, we could make all cards look the same - in bold:

**[<img src="https://avatars3.githubusercontent.com/u/5038030?v=4" width="100px;"/><br /><sub>Charlike</sub>](https://github.com/tunnckocore)**<br />

What do you think?

Btw I'm not going to contribute any code to this, feel free to grab it.

@machour
Copy link
Collaborator

machour commented Nov 2, 2017

Nice catch! This is due to the first row being rendered in a <thead>.

@kentcdodds
Copy link
Collaborator

Yes, I'd love this to be fixed. I don't particularly care how. Would anyone like to submit a pull request?

@machour
Copy link
Collaborator

machour commented Nov 2, 2017

I'll take care of it :)

Berkmann18 added a commit that referenced this issue May 24, 2020
Due to deprecation warnings, I changed the `code` attribute to `status`
to fix
[ac-bot#54](all-contributors/app#54).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants