-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto-fetching #186
Closed
Closed
feat: auto-fetching #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `name-your-contributors` for the upcoming auto-fetching feature
And started improving the auto-fetching
Went for a string comparison approach because RE seemed ineffective and NLP being overkill for matching repo labels to categories.
And removed uneeded code
Re-arranged some label lists/dicts and added more edge case handling (when the label is not categorisable or when it's similar to one of the exceptions).
Added a dataset of labels with categories with the files to test and use them.
The `labels` dataset is more robust (although a long way from being robust enough), there's **finally** a test case checking how well `findBestCategory` does in regards to the dataset
- Added a tokenizer - Improved the dataset (might not be the last time) - Refactored the category finder and the tests (to be done again)
Improved `findCategory` and `labels`.
More labels to work with, a more correct **category finder** (from ~55% accuracy to ~79.5%).
And improved the `tokenizer`
Refactored `token`, tweaked labels and added exceptions and commented out some code (82.025% accuracy :party_hat:)
The accuracy of `findCategory` is now at 95.696% (:hooray:).
Now to 97.468%
Added a learner component utilising `ac-learn` with a saved classifier (`learner.json`). Added the missing `fetch` option in the prompt choices and improved the fetching process
Conflicts: package.json
For some reason the data read by |
Changed the contributor adding process within the `fetch` command function and added rejection handlers where appropriate
... to make it work with `name-your-contributors` which requires `node >= 10.0`
Removed the files that are used for the `nyc` branch (which were in fact useless) and updated the fetching steps in `cli`
Berkmann18
added a commit
that referenced
this pull request
Jul 17, 2019
Berkmann18
added a commit
that referenced
this pull request
Jul 17, 2019
For more info, please check #186
6 tasks
Closing this in favour of #196 |
Berkmann18
added a commit
to Berkmann18/all-contributors-cli
that referenced
this pull request
Oct 3, 2019
For more info, please check all-contributors#186
Berkmann18
pushed a commit
that referenced
this pull request
May 24, 2020
* added function to overwrite incorrect data with know data * updated test snapshots * update snaps * lockfile
Berkmann18
added a commit
that referenced
this pull request
Jul 23, 2023
Berkmann18
added a commit
that referenced
this pull request
Jul 23, 2023
For more info, please check #186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds an auto-fetching mechanism accessible via the
fetch
command (which requires aPRIVATE_TOKEN
env. variable to be set).As noted in all-contributors/all-contributors#18, not all 27 categories can be picked from a GH repo alone so here's what this PR can handle and (roughly) how well;
Why:
To resolve #117 and partly all-contributors/all-contributors#18 (TL;DR: auto adding contributors from a repo).
Re mntnr/name-your-contributors#45
How:
Using
name-your-contributors
andac-learn
.Checklist: