Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add smoia as a contributor #240

Merged
merged 2 commits into from
Jan 4, 2020
Merged

Conversation

allcontributors[bot]
Copy link
Contributor

Adds @smoia as a contributor for code.

This was requested by Berkmann18 in this comment

@Berkmann18
Copy link
Member

Berkmann18 commented Jan 3, 2020

@smoia Are you okay with this?

Oh, and don't forget to update the relevant files in the bot repo when you can.

@smoia
Copy link
Contributor

smoia commented Jan 3, 2020

@Berkmann18 Sure!
I'm on the bot now. I think I don't have to wait for a new release for the bot at this point - but I'll try locally first.
Should I add myself to the all-contributors repo too? If so, for what? Code or docs?

@Berkmann18
Copy link
Member

Awesome, the bot repo is separate so the new CLI releases won't affect it (other than greenkeeper invisibly checking if version changes in the CLI break the bot).
And since the CLI changes were released, you can simply use the latest version of the package.

Should I add myself to the all-contributors repo too? If so, for what? Code or docs?

Seems like I forgot to do that, but the PR is there all-contributors/all-contributors#352.

@Berkmann18 Berkmann18 merged commit b5d1963 into master Jan 4, 2020
@Berkmann18 Berkmann18 deleted the all-contributors/add-smoia branch January 4, 2020 00:39
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants