refactor: return a Promise instead of relying on callback parameter #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Berkmann18
approved these changes
Oct 4, 2020
|
@all-contributors Please add @darekkay for tests. |
|
I've put up a pull request to add @darekkay! 🎉 |
|
🎉 This PR is included in version 6.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix new ESlint issues on master branch.
Why:
The ESlint rule
jest/no-done-callbackwas added here. Because the package versions are not pinned, the current master branch is failing, and so are all new PRs.How:
Fix new ESlint warning by turning callbacks into promises.
Checklist: