Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw a helpful error when unknown contribution type is provided #41

Merged

Conversation

jerodsanto
Copy link
Contributor

As discussed in #40. Happy to change whatever to fit project style/best practices. 💚

Copy link
Collaborator

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent!

@kentcdodds
Copy link
Collaborator

kentcdodds commented Apr 15, 2017

Would you like to add yourself to the contributors table? See the npm scripts 😀

@jerodsanto
Copy link
Contributor Author

@kentcdodds added, thanks!

Note: the npm scripts for this project don't include all-contributors commands yet, so I just used my global version instead. ¯_(ツ)_/¯

@kentcdodds
Copy link
Collaborator

Whoops! I should probably clean up this project and make it more contributor friendly (if you don't mind @jfmengels) :)

@kentcdodds kentcdodds merged commit 77a014f into all-contributors:master Apr 15, 2017
@kentcdodds
Copy link
Collaborator

Thank you so much!

@jfmengels
Copy link
Collaborator

I should probably clean up this project and make it more contributor friendly (if you don't mind @jfmengels) :)

It's good idea, feel free to do it :)

Berkmann18 pushed a commit that referenced this pull request May 24, 2020
* feat: when a repo isn't setup, automatically set it up

* ensure error for non 404s is thrown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants