fix: make selecting at least one contribution type mandatory #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentcdodds
approved these changes
Nov 2, 2017
|
@machour, would you like to be added as a maintainer on the project? I really appreciate your help! @jfmengels, do you mind adding @machour? |
|
Thanks @machour :) |
|
Thank you both for your warm welcoming! |
Berkmann18
added a commit
that referenced
this pull request
May 24, 2020
* chore(package): added commitizen I added `git-cz` * docs(readme): added the cz badge * chore(yarn): updated the yarn.lock file * chore(package): simplified the `commit` script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that people always hit
enterinstead ofspacewhen it comes to selecting the contribution types, resulting in an empty selection.This PR make selecting at least one type mandatory by validating the user input. (tested by adding myself as a contributor 🙊