feat: add --version option #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
machour
requested changes
Nov 8, 2017
cli.js
Outdated
| alias: 'v', | ||
| desc: 'Print installed version', | ||
| type: 'string' | ||
| }) | ||
| .default('contributors', []) |
There was a problem hiding this comment.
This doesn't seem to be the standard way to display version information using yargs:
https://github.com/yargs/yargs/blob/master/docs/api.md#version
Reading the docs, I think that this should be enough:
.alias('v', 'version')
.version()
Also, could you move this block right under alias('h', 'help')? It would make more sense ;)
cli.js
Outdated
| console.log(require('./package.json').version); | ||
| process.exit(0); | ||
| } | ||
|
|
There was a problem hiding this comment.
Shouldn't be needed anymore
|
@machour - you're right! I'm not sure how I missed that! updated 👍 |
machour
requested changes
Nov 9, 2017
cli.js
Outdated
| @@ -29,6 +29,8 @@ var argv = yargs | |||
| .boolean('commit') | |||
| .default('files', ['README.md']) | |||
| .default('contributorsPerLine', 7) | |||
| .alias('v', 'version') | |||
| .version() | |||
There was a problem hiding this comment.
now if we can have these two lines moved up under help, it would be amazing 😅
|
👍 @machour |
|
Thank you so much for baring with me matey! |
|
Quality over quantity any day! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #65