Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Github Enterprise #97

Merged
merged 10 commits into from
Jan 17, 2020

Conversation

hipstersmoothie
Copy link
Contributor

@hipstersmoothie hipstersmoothie commented Jun 8, 2018

What:

  • add isEnterprise config option
  • add function to change hostname if isEnterprise true

depends private key implemented in #95

Why:

I'd like to generate all-contributors for my github enterprise projects.

How:

Adding a new config option.

Checklist:

  • Documentation
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@codecov-io
Copy link

codecov-io commented Jun 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@2d9d39f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #97   +/-   ##
=========================================
  Coverage          ?   58.11%           
=========================================
  Files             ?       19           
  Lines             ?      425           
  Branches          ?       71           
=========================================
  Hits              ?      247           
  Misses            ?      149           
  Partials          ?       29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d9d39f...c569f93. Read the comment docs.

@hipstersmoothie
Copy link
Contributor Author

I'm trying to add myself as a contributor at work but the rate limit has been hit. How can i change this?

@hipstersmoothie
Copy link
Contributor Author

I VPNed into my home and the commands worked. But there doesn't seem to be any docs saying what to do when you see the rate limit.

@hipstersmoothie
Copy link
Contributor Author

Waiting to update until #95 merged cause we changed the same lines

@chinesedfan
Copy link
Contributor

@hipstersmoothie Friendly ping to tell you that #95 has been merged.

@jakebolam
Copy link
Collaborator

@hipstersmoothie I ran into the rate limit too: I've opened the issue #121, and put up a basic PR on this too #122

@Berkmann18
Copy link
Member

@hipstersmoothie Do you still have the time to work on this?

@Berkmann18
Copy link
Member

Friendly ping @hipstersmoothie .

@amaltson
Copy link

amaltson commented Dec 5, 2019

Any chance this will be looked at again? Would love to use it at work too!

@Berkmann18
Copy link
Member

@amaltson Well, @hipstersmoothie doesn't seem to have the time to finish this so it's up for anyone who wants to work on this feature.

@tylerkrupicka
Copy link
Contributor

I'm working with @hipstersmoothie to get this branch updated!

@Berkmann18 Berkmann18 changed the title Support Github Enterprise feat: support Github Enterprise Jan 6, 2020
Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@adierkens
Copy link

Can we get this merged and released?

@amaltson
Copy link

Yes please! Would love to see this go in 😄

@Berkmann18 Berkmann18 merged commit 0965095 into all-contributors:master Jan 17, 2020
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hipstersmoothie
Copy link
Contributor Author

hipstersmoothie commented Jan 17, 2020 via email

Berkmann18 pushed a commit that referenced this pull request May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants