Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[risk=low][no ticket] replace the vulnerable + abandoned ansi-html with ansi-html-community #5756

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

jmthibault79
Copy link
Collaborator

Resolves GHSA-whgm-jr23-g3j9 by replacing ansi-html with ansi-html-community as suggested here.


PR checklist

  • This PR meets the Acceptance Criteria in the JIRA story
  • The JIRA story has been moved to Dev Review
  • This PR includes appropriate unit tests
  • I have run and tested this change locally
  • I have run the E2E tests on ths change against my local UI and/or API server with yarn test-local or yarn test-local-devup
  • If this includes a UI change, I have taken screen recordings or screenshots of the new behavior and notified the PO and UX designer
  • If this includes an API change, I have updated the appropriate Swagger definitions and notified API consumers
  • If this includes a new feature flag, I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later

@@ -131,6 +131,7 @@
"node-gyp": "^4",
"nth-check": "^2.0.1",
"semver-regex": "^3.1.3",
"set-value": "^4.0.1"
"set-value": "^4.0.1",
"ansi-html": "https://registry.yarnpkg.com/ansi-html-community/-/ansi-html-community-0.0.8.tgz#69fbc4d6ccbe383f9736934ae34c3f8290f1bf41"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL this was possible

@jmthibault79 jmthibault79 merged commit eef963f into master Oct 14, 2021
@jmthibault79 jmthibault79 deleted the joel/ui-vulns branch October 14, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants