Fix comments reggression #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes allan2#12 Added a WhiteSpace ParseState and check for a comment after a whitespace. Also return the current position of the iter to correctly strip the comments of from the line to prevent quoted comments or non-whitespace surrounded hash chars. Also updated the tests to match these cases. And added an example code to easily show the output.
BlackDex
force-pushed
the
fix-issue-#12
branch
from
3603dd9
to
1fe4ef0
Compare
allan2
pushed a commit
that referenced
this pull request
Sep 19, 2022
Another fix for multiline support [(PR #18)](#18). Thanks [BlackDex](https://github.com/BlackDex) and [LeoniePhiline](https://github.com/LeoniePhiline)
allan2
pushed a commit
that referenced
this pull request
Sep 19, 2022
Minimum Supported Rust Version is now 1.58.1. [(PR #18)](#21) by [rillian](https://github.com/rillian)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #12
Added a WhiteSpace ParseState and check for a comment after a
whitespace. Also return the current position of the iter to correctly
strip the comments of from the line to prevent quoted comments or
non-whitespace surrounded hash chars.
Also updated the tests to match these cases.
And added an example code to easily show the output.