Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change setProvider() method to use a class constant when specifying providers. #1

Closed
allebb opened this issue May 2, 2015 · 1 comment
Assignees

Comments

@allebb
Copy link
Owner

allebb commented May 2, 2015

A class constant should be used instead for best practice, ease of use and potentially less prone to typo mistakes etc.

This will not break any existing code as the plaintext will work fine too but I personally feel that being able to use a class constant is a more neater solution.

@allebb allebb self-assigned this May 2, 2015
@allebb
Copy link
Owner Author

allebb commented May 11, 2015

Stupidly I forgot that the provider classes utilise the ProviderInterface and are looked up at runtime, therefore it would be silly to manage a static array of provider names given that my initial implementation was to have it dynamic.

@allebb allebb closed this as completed May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant