Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition from version to rc version #286

Closed
krzysiekbielicki opened this issue Mar 28, 2019 · 5 comments
Closed

Transition from version to rc version #286

krzysiekbielicki opened this issue Mar 28, 2019 · 5 comments
Milestone

Comments

@krzysiekbielicki
Copy link
Contributor

incrementPrerelease should work like snapshot versions - increment patch and add -rc1 in case of no previous prerelease.

> ./gradlew currentVersion
1.0.1
> ./gradlew release  -Prelease.versionIncrementer=incrementPrerelease
> ./gradlew currentVersion
1.0.2-rc1
> ./gradlew release  -Prelease.versionIncrementer=incrementPrerelease
> ./gradlew currentVersion
1.0.2-rc2
krzysiekbielicki added a commit to krzysiekbielicki/axion-release-plugin that referenced this issue Mar 28, 2019
krzysiekbielicki added a commit to krzysiekbielicki/axion-release-plugin that referenced this issue Mar 28, 2019
@adamdubiel
Copy link
Member

I left a comment in PR. I think this would introduce breaking change - i would rahter see new incrementer instead.

krzysiekbielicki added a commit to krzysiekbielicki/axion-release-plugin that referenced this issue Mar 29, 2019
adamdubiel pushed a commit that referenced this issue Mar 29, 2019
* [issue #286] Create rc1 in case of no rc version in incrementPrerelase strategy
* [issue #286] initialPreReleaseIfNotOnPrerelease to create rc version, old behavior when absent
@grzegorzwitkowski
Copy link

hi guys, it doesn't work for me in 1.10.0
having a project with single release tag 0.1.1 and calling

gradle-rc1-test (master|✔) $ ./gradlew release -Prelease.dryRun

> Task :verifyRelease
DRY-RUN: uncommitted changes: false
Looking for uncommitted changes..
DRY-RUN: ahead of remote: false
Checking if branch is ahead of remote..
Checking for snapshot versions..

> Task :release
Creating tag: 0.1.1
DRY-RUN: creating tag with name: 0.1.1
Pushing all to remote: origin
DRY-RUN: pushing to remote: origin

still produces 0.1.1 but as I understand it should be 0.1.1-rc1 right?

my config

plugins {
    id 'pl.allegro.tech.build.axion-release' version '1.10.0'
}

scmVersion {
    tag {
        prefix = ''
    }
    versionIncrementer 'incrementPrerelease', [initialPreReleaseIfNotOnPrerelease: 'rc1']
}

project.version = scmVersion.version

@adamdubiel
Copy link
Member

adamdubiel commented Apr 3, 2019

Try 1.10.1, it wasn't released in1.10.0 :) I just published it.

@adamdubiel adamdubiel added this to the 1.10.1 milestone Apr 3, 2019
@grzegorzwitkowski
Copy link

Big thanks, now it works. That's great, I was already afraid I would have to switch to something more reliable from PHP world ;)

@adamdubiel
Copy link
Member

Give us some more time to build the essential tooling ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants